Author zach.ware
Recipients benjamin.peterson, docs@python, gromgull, hynek, pitrou, python-dev, r.david.murray, serhiy.storchaka, stutzbach, vajrasky, zach.ware
Date 2014-02-28.22:22:39
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1393626159.76.0.333127125249.issue20501@psf.upfronthosting.co.za>
In-reply-to
Content
For the UTF-7 comment, I'd go with something like "locale encoding is probably not UTF-7" or "UTF-7 is a convenient, seldom used encoding", or something to that effect.

About writeTmp vs. context manager: as you wish.  It would still be good to convert writeTmp to use a context manager though, but that is a separate issue.  Just cleaning up 2.7 to match 3.x is enough to make me happy :)

For the explicit failure message, perhaps the best we can do in 2.7 is a comment saying that the most likely failure is a UnicodeDecodeError due to the entire file being read when it shouldn't have been.  That can be deduced from the separate comments you already have there (and especially from the issue link), but I think it may be better to just come right out and say it.  If exception chaining means the original exception is kept with a self.fail call in 3.x, I think 3.x should get the explicit failure message, though.  I don't feel too strongly about it, though; I'll leave it to you to change or not as you like :)
History
Date User Action Args
2014-02-28 22:22:39zach.waresetrecipients: + zach.ware, pitrou, benjamin.peterson, stutzbach, r.david.murray, docs@python, python-dev, gromgull, hynek, serhiy.storchaka, vajrasky
2014-02-28 22:22:39zach.waresetmessageid: <1393626159.76.0.333127125249.issue20501@psf.upfronthosting.co.za>
2014-02-28 22:22:39zach.warelinkissue20501 messages
2014-02-28 22:22:39zach.warecreate