Author terry.reedy
Recipients Saimadhav.Heblikar, steven.daprano, taleinat, terry.reedy
Date 2014-02-27.16:26:55
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1393518415.63.0.476473716673.issue20792@psf.upfronthosting.co.za>
In-reply-to
Content
We do not usually make pure style changes in a file unless the code is being reviewed and edited. Even then, I focus on changes that make the file easier to read and understand, as is necessary to write tests. One example is adding missing spaces after commas in function definitions and calls (not a problem in this file, as far as I see). Another is to add PEP8 style docstrings to document the behavior being tested. That is an issue for this file. The name clashes do not bother me: 'file' is no longer a builtin in 3.x; 'sorted' was used in the file before the builtin was added (though I might think of something different if I were writing today). So lets leave the names alone and focus on good docstrings.
History
Date User Action Args
2014-02-27 16:26:55terry.reedysetrecipients: + terry.reedy, taleinat, steven.daprano, Saimadhav.Heblikar
2014-02-27 16:26:55terry.reedysetmessageid: <1393518415.63.0.476473716673.issue20792@psf.upfronthosting.co.za>
2014-02-27 16:26:55terry.reedylinkissue20792 messages
2014-02-27 16:26:55terry.reedycreate