➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author serhiy.storchaka
Recipients barry, eli.bendersky, ethan.furman, pitrou, serhiy.storchaka, vajrasky
Date 2014-02-17.16:57:29
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1392656249.87.0.284504538016.issue20654@psf.upfronthosting.co.za>
In-reply-to
Content 
The fix itself looks good, but the test can be better. You write temporary file in current directory. this can fail for different reasons, Python can crash and left undeleted file, this file can overwrite existing file. The render_doc() function is last module level function in a traceback, and it can be used for testing, temporary file will be not needed.
History
Date User Action Args
2014-02-17 16:57:29serhiy.storchakasetrecipients: + serhiy.storchaka, barry, pitrou, eli.bendersky, ethan.furman, vajrasky
2014-02-17 16:57:29serhiy.storchakasetmessageid: <1392656249.87.0.284504538016.issue20654@psf.upfronthosting.co.za>
2014-02-17 16:57:29serhiy.storchakalinkissue20654 messages
2014-02-17 16:57:29serhiy.storchakacreate