Author serhiy.storchaka
Recipients rhettinger, serhiy.storchaka
Date 2014-02-14.12:01:10
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <2028630.oKFmrDVq1R@raxxla>
In-reply-to <1392344161.29.0.585961065902.issue20547@psf.upfronthosting.co.za>
Content
> Additionally, the "more specific tests" introduce some additional opacity
> that is harmful for knowing what methods and operators are specifically
> used internally in test method.  For end users of Python, they don't have
> to worry much about this, but we as developers of core types really care
> whether self.assertLessThan(x, y) really does x < y, or x.__lt__(y), or
> "not y >= x", etc.

If the test explicitly designed to test relation or boolean operations, I 
leave it as is. I try to be very careful.

After more careful reviewing this patch, I have found than some tests 
shouldn't be changed, because they produce utterly large error message in case 
of a failure (even if resulted message is truncated, as in case of 
assertEqual, large intermediate strings are created). Here is corrected patch.
Files
File name Uploaded
test_bigmem_asserts_2.patch serhiy.storchaka, 2014-02-14.12:01:10
History
Date User Action Args
2014-02-14 12:01:11serhiy.storchakasetrecipients: + serhiy.storchaka, rhettinger
2014-02-14 12:01:11serhiy.storchakalinkissue20547 messages
2014-02-14 12:01:10serhiy.storchakacreate