This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients Jeffrey.Armstrong, serhiy.storchaka, vstinner
Date 2014-02-12.09:46:04
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1392198364.66.0.39347217285.issue20596@psf.upfronthosting.co.za>
In-reply-to
Content
I don't think that "#ifdef MS_WINDOWS" is very useful, you can drop it. So get something simpler:

/* Portable macro for wcstok(): on Windows, it is not thread-safe, the state
 * argument is ignored, except if Visual Studio is used. */
#ifdef _MSC_VER
#  define Py_WCSTOK(str, tok, state)  wcstok_s(str, tok, state)
#elif defined(MS_WINDOWS) && !defined(__WATCOMC__)
#  define Py_WCSTOK(str, tok, state)  wcstok(str, tok)
#else
#  define Py_WCSTOK(str, tok, state)  wcstok(str, tok, state)
#endif

But I don't like "#elif defined(MS_WINDOWS) && !defined(__WATCOMC__)": what are the other compilers on Windows which provide wcstok() with 2 parameters?
History
Date User Action Args
2014-02-12 09:46:04vstinnersetrecipients: + vstinner, serhiy.storchaka, Jeffrey.Armstrong
2014-02-12 09:46:04vstinnersetmessageid: <1392198364.66.0.39347217285.issue20596@psf.upfronthosting.co.za>
2014-02-12 09:46:04vstinnerlinkissue20596 messages
2014-02-12 09:46:04vstinnercreate