Author vstinner
Recipients gvanrossum, larry, loewis, pitrou, sbt, vstinner, zach.ware
Date 2014-02-11.23:22:53
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1392160973.89.0.707607952145.issue20414@psf.upfronthosting.co.za>
In-reply-to
Content
Oh, I agree that refactoring is too late for Python 3.4. Anyway, I thought that the two modules had just duplicated code, but in fact they also have a different API. So it's not so easy to merge them. It would probably be easier if asyncio and multiprocessing use the same module.

> Is overlapped_dealloc-2.patch fixing something important?

overlapped_dealloc.patch was just the same change from _winapi to _overlapped to fix #19565.

Richard fixed #19565, not me.

Martin asked me to change overlapped_dealloc.patch but I'm not sure that I understood his request, that why I asked for a review of  overlapped_dealloc-2.patch.

I don't know if it's important to fix #19565 in the _overlapped module. _winapi has a test of overlapped operations still running at Python exit, but _overlapped doesn't have such test yet. With asyncio is may become more likely to exit with pending overlapped operations.
History
Date User Action Args
2014-02-11 23:22:53vstinnersetrecipients: + vstinner, gvanrossum, loewis, pitrou, larry, sbt, zach.ware
2014-02-11 23:22:53vstinnersetmessageid: <1392160973.89.0.707607952145.issue20414@psf.upfronthosting.co.za>
2014-02-11 23:22:53vstinnerlinkissue20414 messages
2014-02-11 23:22:53vstinnercreate