Message210387
> Whoops, forgot to fix all the breakage in clinic_test.py. It's good now.
Ah, you re-uploaded the patch and reset my code review comments. I'll repeat them here, just in case.
Reviewed the patch.
- In one of the C files I saw this signature: "(/)" -- probably should be just "()"
- signature for 'type' builtin was '(object_or_name, bases, dict)', which is a correct signature (minus the groups/optional parameters). In this patch it's a ValueError. Can we restore the prior behaviour? If not, then test_signature_on_class_without_init is incorrect now, as it should throw a ValueError for metaclasses.
- and some other minor stuff |
|
Date |
User |
Action |
Args |
2014-02-06 14:35:08 | yselivanov | set | recipients:
+ yselivanov, georg.brandl, ncoghlan, larry, zach.ware, serhiy.storchaka |
2014-02-06 14:35:08 | yselivanov | set | messageid: <1391697308.65.0.765895519771.issue20530@psf.upfronthosting.co.za> |
2014-02-06 14:35:08 | yselivanov | link | issue20530 messages |
2014-02-06 14:35:08 | yselivanov | create | |
|