Author gdr@garethrees.org
Recipients gdr@garethrees.org, zach.ware
Date 2014-02-04.18:29:17
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1391538558.08.0.667277851686.issue20510@psf.upfronthosting.co.za>
In-reply-to
Content
I normally try not to make changes "while we're in here" for fear of
introducing errors! But I guess the test cases are less critical, so
I've taken your review comments as a license to submit a revised patch
that:

* incorporates your suggestion to use assert_python_ok from
  test.script_helper, instead of subprocess.call;
* replaces the other uses of subprocess.call with
  assert_python_failure and adds a check on stdout;
* cleans up the assertion-testing code using the context manager form
  of unittest.TestCase.assertRaises.

I've signed and submitted a contributor agreement as requested.
History
Date User Action Args
2014-02-04 18:29:18gdr@garethrees.orgsetrecipients: + gdr@garethrees.org, zach.ware
2014-02-04 18:29:18gdr@garethrees.orgsetmessageid: <1391538558.08.0.667277851686.issue20510@psf.upfronthosting.co.za>
2014-02-04 18:29:18gdr@garethrees.orglinkissue20510 messages
2014-02-04 18:29:17gdr@garethrees.orgcreate