This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author lars.gustaebel
Recipients christian.heimes, edulix, lars.gustaebel, loewis, serhiy.storchaka
Date 2014-01-29.11:26:39
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1390994800.36.0.462210544435.issue18321@psf.upfronthosting.co.za>
In-reply-to
Content
I cannot yet go into the details, because I have not tested the patch.

The comments, docstrings and quoting are not very consistent with the rest of the module. There are a few spelling mistakes. The open_volume() method is more or less a copy of the open() method which is not optimal.

The patch adds a lot of complexity to the tarfile module for a use case that only a few connoisseurs benefit from. It seems to alter some inherent TarFile mechanics that people might rely on, e.g. the members attribute contains only the members stored in the current volume not the overall entirety of members. Does this patch reliably allow random-access?

Would it be possible/easier to add the same functionality using a separate class MultiVolumeTarFile instead?
History
Date User Action Args
2014-01-29 11:26:40lars.gustaebelsetrecipients: + lars.gustaebel, loewis, christian.heimes, serhiy.storchaka, edulix
2014-01-29 11:26:40lars.gustaebelsetmessageid: <1390994800.36.0.462210544435.issue18321@psf.upfronthosting.co.za>
2014-01-29 11:26:40lars.gustaebellinkissue18321 messages
2014-01-29 11:26:39lars.gustaebelcreate