Message209261
Christian Heimes just posted this to python-dev:
____________________________________________________________
Coverity has detected an issue in this commit:
** CID 1164423: Division or modulo by zero (DIVIDE_BY_ZERO)
/Modules/audioop.c: 1375 in audioop_ratecv_impl()
________________________________________________________________________________________________________
*** CID 1164423: Division or modulo by zero (DIVIDE_BY_ZERO)
/Modules/audioop.c: 1375 in audioop_ratecv_impl()
1369 without spurious overflow is the challenge; we can
1370 settle for a reasonable upper bound, though, in this
1371 case ceiling(len/inrate) * outrate. */
1372
1373 /* compute ceiling(len/inrate) without overflow */
1374 Py_ssize_t q = len > 0 ? 1 + (len - 1) / inrate : 0;
>>> CID 1164423: Division or modulo by zero (DIVIDE_BY_ZERO)
>>> In expression "9223372036854775807L / q", division by expression
"q" which may be zero has undefined behavior.
1375 if (outrate > PY_SSIZE_T_MAX / q / bytes_per_frame)
1376 str = NULL;
1377 else
1378 str = PyBytes_FromStringAndSize(NULL,
1379 q * outrate *
bytes_per_frame);
1380 } |
|
Date |
User |
Action |
Args |
2014-01-26 00:24:43 | larry | set | recipients:
+ larry, python-dev, serhiy.storchaka |
2014-01-26 00:24:43 | larry | set | messageid: <1390695883.21.0.497704215988.issue20133@psf.upfronthosting.co.za> |
2014-01-26 00:24:43 | larry | link | issue20133 messages |
2014-01-26 00:24:42 | larry | create | |
|