Author terry.reedy
Recipients Todd.Rovito, bagratte, edmond.burnett, eric.araujo, ezio.melotti, kjohnson, python-dev, roger.serwy, terry.reedy
Date 2014-01-23.06:29:55
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1390458596.75.0.0345174099626.issue17390@psf.upfronthosting.co.za>
In-reply-to
Content
Edmond and Kent, thanks for the patch.  Ezio, thanks for re-opening.

After testing the patch with and without 'Editor', I preferred without. It is slightly redundant and noisy, especially when editing EditorWindow.py ;-). Also, Windows 7 stacks icons for windows belonging to a program under the program icon on the task bar. When the mouse is over the program icon, it pop up a window of *limited* width listing the window titles. The popup is narrow enough that paths to Idle test files in my repository clone get truncated when 'Editor' is added.

I suspect that adding '''else: filename = "Untitled"''' to short_title() makes the corresponding '''else: title = "Untitled"''' in saved_change_hook() useless. I will check later for possible removal.

Since I sometimes have multiple Find in File Output windows, I would like to expand their titles also. Since the Python version is irrelevant. I am thinking of
  Python: Matches for "<re>"
But I think their may be other uses of Output windows (easily found by searching for "Output" ;-).  In any case, extensions and new features should be free to use use OutputWindow. So we cannot generically modify OutputWindow.short_title . If the self parameter of short_title does not somehow indicate that the output is for Find in Files, we can subclass and over-ride.

class FiFWindow(OutputWindow):
  def short_title(self):
    return <fif title>
History
Date User Action Args
2014-01-23 06:29:56terry.reedysetrecipients: + terry.reedy, kjohnson, ezio.melotti, roger.serwy, eric.araujo, Todd.Rovito, python-dev, bagratte, edmond.burnett
2014-01-23 06:29:56terry.reedysetmessageid: <1390458596.75.0.0345174099626.issue17390@psf.upfronthosting.co.za>
2014-01-23 06:29:56terry.reedylinkissue17390 messages
2014-01-23 06:29:55terry.reedycreate