This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author taleinat
Recipients Yury.Selivanov, brett.cannon, georg.brandl, jkloth, larry, serhiy.storchaka, taleinat, vajrasky, zach.ware
Date 2014-01-22.12:50:11
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1390395012.1.0.786365802308.issue20341@psf.upfronthosting.co.za>
In-reply-to
Content
Found two bugs in the draft patch in Objects/longobject.c:

1) In _PyLong_NullableIntConverter, there is no index variable, so the Py_DECREF and Py_XDECREF need to be removed from the end of the function.

2) In _PyLong_NullablePy_ssize_tConverter, the index variable will point to a Python object only when both if blocks are skipped. Therefore, the Py_XDECREF after "fail:" at the end of the function needs to be removed.

With these two changes, I successfully used this patch to convert deque_init in Modules/_collectionsmodule.c, simplifying the input validation code considerably.
History
Date User Action Args
2014-01-22 12:50:12taleinatsetrecipients: + taleinat, brett.cannon, georg.brandl, larry, jkloth, Yury.Selivanov, zach.ware, serhiy.storchaka, vajrasky
2014-01-22 12:50:12taleinatsetmessageid: <1390395012.1.0.786365802308.issue20341@psf.upfronthosting.co.za>
2014-01-22 12:50:12taleinatlinkissue20341 messages
2014-01-22 12:50:11taleinatcreate