Author serhiy.storchaka
Recipients Claudiu.Popa, mvignali, serhiy.storchaka, vajrasky
Date 2014-01-21.16:44:48
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1390322688.18.0.294445065859.issue19990@psf.upfronthosting.co.za>
In-reply-to
Content
In general the patch LGTM, but additional tests can be added.

Needed various tests for imghdr.what() arguments:

* First argument is bytes, int or None.
* First argument is a name of non-existent file.
* First argument is text stream.
* First argument is output stream.
* First argument is closed stream.
* First argument is non-seekable stream.
* Second argument is bytearray.
* Second argument is str.
* Second argument is None.

Try to insert test function which handles one of already supported format at the front of imghdr.test.
History
Date User Action Args
2014-01-21 16:44:48serhiy.storchakasetrecipients: + serhiy.storchaka, Claudiu.Popa, vajrasky, mvignali
2014-01-21 16:44:48serhiy.storchakasetmessageid: <1390322688.18.0.294445065859.issue19990@psf.upfronthosting.co.za>
2014-01-21 16:44:48serhiy.storchakalinkissue19990 messages
2014-01-21 16:44:48serhiy.storchakacreate