Message207133
Patch looks good to me. I like the choice to drop the parens. This is my first time reviewing a change; did I go through the right mechanics? I clicked Review on the issue's patch, looked at the diff, and a published a message similar to this one. Was I supposed to do something else? Is that message what "Review" is looking for? Was the "Please review" directed at me? Am I supposed to make a comment like "looks good" here? do something else? |
|
Date |
User |
Action |
Args |
2014-01-01 14:02:31 | MLModel | set | recipients:
+ MLModel, ncoghlan, gennad |
2014-01-01 14:02:30 | MLModel | set | messageid: <1388584950.88.0.567436397945.issue20077@psf.upfronthosting.co.za> |
2014-01-01 14:02:30 | MLModel | link | issue20077 messages |
2014-01-01 14:02:30 | MLModel | create | |
|