Author zach.ware
Recipients zach.ware
Date 2013-12-20.16:30:47
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1387557050.08.0.350325342144.issue20035@psf.upfronthosting.co.za>
In-reply-to
Content
The attached patch refactors tkinter._fix's main logic into a function called 'fix_environ' which is called unconditionally on import, and adds a function 'unfix_environ' to undo the effects of fix_environ.  fix/unfix_environ are then used in all test files that import tkinter (test___all__, test_tcl, test_tk, test_ttk_guionly, test_ttk_textonly, test_idle) to ensure that the environment is properly set to allow Tcl to load and to suppress regrtest's warning that os.environ has been modified.

Since tkinter._fix is an implementation detail, I assume this change isn't against the 'no new features' policy of all currently open branches, but if this needs to wait until 3.5, that's ok with me.
History
Date User Action Args
2013-12-20 16:30:50zach.waresetrecipients: + zach.ware
2013-12-20 16:30:50zach.waresetmessageid: <1387557050.08.0.350325342144.issue20035@psf.upfronthosting.co.za>
2013-12-20 16:30:49zach.warelinkissue20035 messages
2013-12-20 16:30:49zach.warecreate