Author ncoghlan
Recipients chris.jerdonek, eric.araujo, eric.snow, italip, ncoghlan, pitrou
Date 2013-12-09.02:04:40
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1386554680.95.0.825214907365.issue15403@psf.upfronthosting.co.za>
In-reply-to
Content
I took a look at this last night, and found the combination of moving stuff around *and* refactoring it at the same time was too hard to review.

So, once the PEP 451 changes for runpy are done, I think it would make more sense to tackle this as at least three patches:

1. Do the refactoring *within* test_runpy to make the helper API a bit cleaner (this should also use types.SimpleNamespace where appropriate rather than a custom alternative)

2. Move the helper API out to a documented test.support.package_helper module without altering the test.support API

3+. Refactor other test modules to use the now shared API (there may be some pkg related functionality to move out of script_helper as well).
History
Date User Action Args
2013-12-09 02:04:41ncoghlansetrecipients: + ncoghlan, pitrou, eric.araujo, chris.jerdonek, eric.snow, italip
2013-12-09 02:04:40ncoghlansetmessageid: <1386554680.95.0.825214907365.issue15403@psf.upfronthosting.co.za>
2013-12-09 02:04:40ncoghlanlinkissue15403 messages
2013-12-09 02:04:40ncoghlancreate