Author r.david.murray
Recipients barry, lpolzer, r.david.murray, richard, vstinner
Date 2013-11-20.13:53:52
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1384955633.6.0.814798659092.issue19662@psf.upfronthosting.co.za>
In-reply-to
Content
This bug was apparently introduced as part of the work from issue 4184 in python 3.2.  My guess, looking at the code, is that the module simply didn't work before that patch, since it would have been attempting to join binary data using a string join (''.join(...)).  Richard says in the issue that he wrote tests, so he probably figured out it wasn't working and "fixed" it.  It looks like there was no final review of his patch (at least not via the tracker...the patch uploaded to the tracker did not include the decode).  Not that a final review would necessarily have caught the bug...

The problem here is backward compatibility.

In terms of the API, it really ought to be producing binary data, and not decoding at all.  But, at the time he wrote the patch the email package couldn't handle binary data (Richard's patch landed in July 2010, binary support in the email package landed in October), so presumably nobody was thinking about binary emails.

I'm really not sure what to do here, I'll have to give it some thought.
History
Date User Action Args
2013-11-20 13:53:53r.david.murraysetrecipients: + r.david.murray, barry, richard, vstinner, lpolzer
2013-11-20 13:53:53r.david.murraysetmessageid: <1384955633.6.0.814798659092.issue19662@psf.upfronthosting.co.za>
2013-11-20 13:53:53r.david.murraylinkissue19662 messages
2013-11-20 13:53:52r.david.murraycreate