Message202976
On Windows 64-bit, Visual Studio generates a lot of warnings because Py_ssize_t values are downcasted to int.
Attached patch fixes all warnings and move the final downcast into compiler_addop_i(). This function uses an assertion to check that integer parameter fits into an C int type. I don't know if it's safe to "return 0" on overflow error.
The patch fixes also some indentation issues seen was I wrote the patch.
Nobody complained before, I don't know if the bugs can be seen in practice, so I prefer to not touch Python 2.7 nor 3.2. |
|
Date |
User |
Action |
Args |
2013-11-15 23:08:08 | vstinner | set | recipients:
+ vstinner, benjamin.peterson, serhiy.storchaka |
2013-11-15 23:08:07 | vstinner | set | messageid: <1384556887.78.0.0801644931994.issue19617@psf.upfronthosting.co.za> |
2013-11-15 23:08:07 | vstinner | link | issue19617 messages |
2013-11-15 23:08:07 | vstinner | create | |
|