Author eric.snow
Recipients Arfrever, berker.peksag, brett.cannon, eric.snow, larry, ncoghlan
Date 2013-11-11.23:55:36
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1384214136.52.0.403977209668.issue18864@psf.upfronthosting.co.za>
In-reply-to
Content
> (I still like the idea of passing
> a target to importlib.find_spec - I just no longer think we should be
> passing that down to the finders themselves).

Passing the target to the finders isn't just for the sake of any implicit "check_target" test, though that was the original motivator.  It also allows the finder to decide between multiple loaders based on other criteria related to the target (but not necessarily the loader).  I think it was a good addition to the API regardless.

> Another thing we need to check we have a test for: ensuring reloading a
> namespace module picks up new directories added since it was first loaded.

Agreed.  Furthermore, such a test is worthwhile outside the context of PEP 451.  I'm tempted to say we're already covered with existing tests, but reload is goofy enough that an explicit test is worth it.

> This would all be so much easier if reloading wasn't supported in the first
> place :)

So very true. :)
History
Date User Action Args
2013-11-11 23:55:36eric.snowsetrecipients: + eric.snow, brett.cannon, ncoghlan, larry, Arfrever, berker.peksag
2013-11-11 23:55:36eric.snowsetmessageid: <1384214136.52.0.403977209668.issue18864@psf.upfronthosting.co.za>
2013-11-11 23:55:36eric.snowlinkissue18864 messages
2013-11-11 23:55:36eric.snowcreate