Author ncoghlan
Recipients barry, ezio.melotti, flox, lemburg, ncoghlan, vstinner
Date 2013-11-10.14:39:37
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CADiSq7e7a_Jpt==WqYiU0KrDO-c5h0MmUn6G30s4iRO4HYD5jg@mail.gmail.com>
In-reply-to <527F884F.7090607@egenix.com>
Content
On 10 November 2013 23:21, Marc-Andre Lemburg <report@bugs.python.org> wrote:
>
> This doesn't look right:
>
> diff -r 1ee45eb6aab9 Include/pyerrors.h
> --- a/Include/pyerrors.h        Sat Nov 09 23:15:52 2013 +0200
> +++ b/Include/pyerrors.h        Sun Nov 10 22:54:04 2013 +1000
> ...
> +PyAPI_FUNC(PyObject *) _PyErr_TrySetFromCause(
> +    const char *prefix_format,   /* ASCII-encoded string  */
> +    ...
> +    );

After sending my previous reply, I realised you may have been
referring to the comment. I copied that from the PyErr_Format
signature. According to
http://docs.python.org/dev/c-api/unicode.html#PyUnicode_FromFormat,
the format string still has to be ASCII-encoded, and if that's no
longer true, it's a separate bug from this one that will require a
docs fix as well.

> In the error messages, I'd use "codecs.encode()" and "codecs.decode()"
> (ie. with parens) instead of "codecs.encode" and "codecs.decode".

Forgot to reply to this part - I like it, will switch it over before committing.
History
Date User Action Args
2013-11-10 14:39:38ncoghlansetrecipients: + ncoghlan, lemburg, barry, vstinner, ezio.melotti, flox
2013-11-10 14:39:38ncoghlanlinkissue17828 messages
2013-11-10 14:39:37ncoghlancreate