Author zach.ware
Recipients Arfrever, ezio.melotti, python-dev, serhiy.storchaka, vajrasky, vstinner, zach.ware
Date 2013-10-30.17:15:12
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1383153312.52.0.308908659444.issue19424@psf.upfronthosting.co.za>
In-reply-to
Content
Adding to Vajrasky's report, the same commit also adds 3 warnings when building on Windows:

..\Objects\unicodeobject.c(10588): warning C4018: '>' : signed/unsigned mismatch [P:\Projects\OSS\Python\cpython\PCbuild\pythoncore.vcxproj]
..\Objects\unicodeobject.c(10592): warning C4018: '>' : signed/unsigned mismatch [P:\Projects\OSS\Python\cpython\PCbuild\pythoncore.vcxproj]
..\Objects\unicodeobject.c(10594): warning C4018: '>' : signed/unsigned mismatch [P:\Projects\OSS\Python\cpython\PCbuild\pythoncore.vcxproj]

Vajrasky's patch doesn't fix the Windows warnings (but doesn't create any new ones either); the attached patch does (but likely doesn't do anything for the other).

I don't know nearly enough C to say whether my patch is any good or not, just enough to say it compiles, doesn't break anything immediately obvious, and removes the warnings on Windows.
History
Date User Action Args
2013-10-30 17:15:12zach.waresetrecipients: + zach.ware, vstinner, ezio.melotti, Arfrever, python-dev, serhiy.storchaka, vajrasky
2013-10-30 17:15:12zach.waresetmessageid: <1383153312.52.0.308908659444.issue19424@psf.upfronthosting.co.za>
2013-10-30 17:15:12zach.warelinkissue19424 messages
2013-10-30 17:15:12zach.warecreate