This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vajrasky
Recipients berker.peksag, jaraco, orsenthil, vajrasky
Date 2013-10-01.14:11:38
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
Okay, attached the patch based on your comment, Senthil Kumaran. Thanks.

The reason I use isinstance to check the type is because I want to support the inheritance as much as possible.

>>> class new_str(str):
...   pass
>>> urljoin(new_str('') + new_str('hehe'))
will not work with the newest patch.

Also, in Lib/urllib/, most of the time, we use isinstance(x, str) not type(x) == str.

But I don't know. Maybe it does not matter.
Date User Action Args
2013-10-01 14:11:39vajraskysetrecipients: + vajrasky, jaraco, orsenthil, berker.peksag
2013-10-01 14:11:39vajraskysetmessageid: <>
2013-10-01 14:11:39vajraskylinkissue19094 messages
2013-10-01 14:11:38vajraskycreate