This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author ecatmur
Recipients ecatmur, sbt
Date 2013-09-26.09:45:36
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1380188737.01.0.479330452192.issue19096@psf.upfronthosting.co.za>
In-reply-to
Content
Suggested patch: https://bitbucket.org/ecatmur/cpython/compare/19096-multiprocessing-race..#diff

Move the worker_handler.join() to immediately after setting the worker handler thread state to TERMINATE.  This is a safe change as nothing in the moved-over code affects the worker handler thread, except by terminating workers which is precisely what we don't want to happen.  In addition, this is near-equivalent behaviour to current close() + join(), which is well-tested.

Also: write tests; and modify Pool.__init__ to refer to its static methods using self rather than class name, to make them overridable for testing purposes.
History
Date User Action Args
2013-09-26 09:45:37ecatmursetrecipients: + ecatmur, sbt
2013-09-26 09:45:37ecatmursetmessageid: <1380188737.01.0.479330452192.issue19096@psf.upfronthosting.co.za>
2013-09-26 09:45:36ecatmurlinkissue19096 messages
2013-09-26 09:45:36ecatmurcreate