This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author serhiy.storchaka
Recipients kristjan.jonsson, orsenthil, pitrou, r.david.murray, serhiy.storchaka
Date 2013-09-20.18:39:02
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1379702342.94.0.212751349636.issue19009@psf.upfronthosting.co.za>
In-reply-to
Content
> A separate new function now takes care of the reading of chunk-header and tail.  This simplifies the other functions.

Good. It is even better than I expected.

> Do we gain anything by doing that, would it change the code? or would it merely be for the benefit of ABC?

Yes, it for the benefit of ABC. Some code tests isinstance(file, io.BufferedIOBase) and wraps stream in BufferedReader if it is false.

> Note that the chunk protocol was wrong and I fixed the unittests:  The final chunk is a _valid_ zero length chunk, i.e. 0\r\n\r\n.  It contains two eol tokens like other chunks, one at the end of the length, the other at the end of the(null) payload.

How new code processes invalid final chunk 0\r\n? We need test to check that there is no degradation.

Perhaps it relates to behavior change which I mention in the comment on Rietveld.
History
Date User Action Args
2013-09-20 18:39:02serhiy.storchakasetrecipients: + serhiy.storchaka, orsenthil, pitrou, kristjan.jonsson, r.david.murray
2013-09-20 18:39:02serhiy.storchakasetmessageid: <1379702342.94.0.212751349636.issue19009@psf.upfronthosting.co.za>
2013-09-20 18:39:02serhiy.storchakalinkissue19009 messages
2013-09-20 18:39:02serhiy.storchakacreate