Author akuchling
Recipients Arfrever, akuchling, barry, benjamin.peterson, christian.heimes, georg.brandl, giampaolo.rodola, larry, r.david.murray, serhiy.storchaka
Date 2013-09-15.16:31:56
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1379262717.28.0.135464945849.issue16042@psf.upfronthosting.co.za>
In-reply-to
Content
Here's a final proposed version of the patch for 2.6 that adds a test.  Changes made:

* code now raises SMTPResponseException instead of a new SMTPLineTooLong exception; bwarsaw deemed that adding a new exception class was changing the module API.

* we looked at Serhiy's suggestion to move the length check into the 'while' loop's condition and decided not to -- the code is more obvious with the separate if/break.

* the test class is a cut-and-paste and slight modification of the BadHELOServerTests class; I didn't try to unify them in some way.
History
Date User Action Args
2013-09-15 16:31:57akuchlingsetrecipients: + akuchling, barry, georg.brandl, larry, giampaolo.rodola, christian.heimes, benjamin.peterson, Arfrever, r.david.murray, serhiy.storchaka
2013-09-15 16:31:57akuchlingsetmessageid: <1379262717.28.0.135464945849.issue16042@psf.upfronthosting.co.za>
2013-09-15 16:31:57akuchlinglinkissue16042 messages
2013-09-15 16:31:57akuchlingcreate