Author tim.peters
Recipients brian.curtin, christian.heimes, serhiy.storchaka, terry.reedy, tim.peters
Date 2013-09-01.17:15:42
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1378055743.1.0.609382309527.issue18889@psf.upfronthosting.co.za>
In-reply-to
Content
Suggest caution here.  test_sax fails the same way for me too (Windows Vista), under both the released 3.3.2 and a Python built from the current hg default branch.

However, these files (test.xml and test.xml.out) have not changed since the Python 2.7 line - the \r\n line endings have _always_ been there, and test_sax works fine under (e.g.) Python 2.7.5 on Windows.

So it's not that the files have changed, it must be that Python is behaving differently.

Unfortunately, I don't know anything about what test_sax is trying to do.  I do see that under 2.7, test_sax does

xml_test_out = open(TEST_XMLFILE_OUT).read()

but 3.3 does

with open(TEST_XMLFILE_OUT, 'rb') as f:
    xml_test_out = f.read()

That is, 2.7 opens the file for reading in text mode, but 3.3 opens it in binary mode.  That makes a big difference for text files under Windows.

It's also disturbing that the Windows buildbots don't fail.  There is no change in "environment" that should affect the bytes seen when a file is read - and the buildbots "should be" seeing, byte for byte, the same files developers and users see.
History
Date User Action Args
2013-09-01 17:15:43tim.peterssetrecipients: + tim.peters, terry.reedy, christian.heimes, brian.curtin, serhiy.storchaka
2013-09-01 17:15:43tim.peterssetmessageid: <1378055743.1.0.609382309527.issue18889@psf.upfronthosting.co.za>
2013-09-01 17:15:43tim.peterslinkissue18889 messages
2013-09-01 17:15:42tim.peterscreate