Author asvetlov
Recipients asvetlov, christian.heimes, giampaolo.rodola, pitrou, serhiy.storchaka, vstinner
Date 2013-09-01.05:20:40
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1378012842.08.0.366626921397.issue18882@psf.upfronthosting.co.za>
In-reply-to
Content
Uploaded new patch.

> - the doc addition needs a "versionadded" tag
Fixed.

> - "The main thread is the thread that the OS creates to run application.": I would rephrase this "In normal conditions, the main thread is the thread from which the Python interpreter was started".
Fixed.

> - in the tests:
> +        self.assertEqual(data, "Thread-1\nTrue\nTrue\n")
> 
> Hmm, how do you know it will be called "Thread-1"?
> I would give a specific name to the Thread, so as to make the test deterministic.
In this test main thread after forking is always first thread created by python. That's why it always is called 'Thread-1'. 

> +        self.assertEqual(rc, 0)
> 
> You don't need this, it is already ensured by assert_python_ok().
Fixed.

> - in threading.py, why doesn't _exitfunc() reuse the _main_thread global variable, instead of taking it as a parameter?
Fixed.
History
Date User Action Args
2013-09-01 05:20:42asvetlovsetrecipients: + asvetlov, pitrou, vstinner, giampaolo.rodola, christian.heimes, serhiy.storchaka
2013-09-01 05:20:42asvetlovsetmessageid: <1378012842.08.0.366626921397.issue18882@psf.upfronthosting.co.za>
2013-09-01 05:20:42asvetlovlinkissue18882 messages
2013-09-01 05:20:41asvetlovcreate