Author pitrou
Recipients asvetlov, christian.heimes, giampaolo.rodola, pitrou, serhiy.storchaka, vstinner
Date 2013-08-31.17:53:15
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1377971596.23.0.729742577701.issue18882@psf.upfronthosting.co.za>
In-reply-to
Content
Ok, some comments about the patch (no "review" links appears so I'm gonna do it inline here):

- the doc addition needs a "versionadded" tag

- "The main thread is the thread that the OS creates to run application.": I would rephrase this "In normal conditions, the main thread is the thread from which the Python interpreter was started".

- in the tests:
+        self.assertEqual(data, "Thread-1\nTrue\nTrue\n")

Hmm, how do you know it will be called "Thread-1"?
I would give a specific name to the Thread, so as to make the test deterministic.

+        self.assertEqual(rc, 0)

You don't need this, it is already ensured by assert_python_ok().

- in threading.py, why doesn't _exitfunc() reuse the _main_thread global variable, instead of taking it as a parameter?
History
Date User Action Args
2013-08-31 17:53:16pitrousetrecipients: + pitrou, vstinner, giampaolo.rodola, christian.heimes, asvetlov, serhiy.storchaka
2013-08-31 17:53:16pitrousetmessageid: <1377971596.23.0.729742577701.issue18882@psf.upfronthosting.co.za>
2013-08-31 17:53:16pitroulinkissue18882 messages
2013-08-31 17:53:15pitroucreate