Author neologix
Recipients alex, christian.heimes, dstufft, hynek, jcea, neologix, pitrou, python-dev, tarek, vstinner
Date 2013-08-24.17:49:35
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAH_1eM2TZc4kbQKNhSVAB4o9sdZR+DJURmDArVrpj8YHr1KnLQ@mail.gmail.com>
In-reply-to <3cGttX4hM0z7Ljp@mail.python.org>
Content
> New changeset fe949918616c by Antoine Pitrou in branch 'default':
> Issue #18756: Improve error reporting in os.urandom() when the failure is due to something else than /dev/urandom not existing.
> http://hg.python.org/cpython/rev/fe949918616c

Antoine, this changeset broke Tiger buildbots badly:
"""
======================================================================
ERROR: test_urandom_failure (test.test_os.URandomTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/db3l/buildarea/3.x.bolen-tiger/build/Lib/test/test_os.py",
line 1033, in test_urandom_failure
ValueError: not allowed to raise maximum limit
"""

http://buildbot.python.org/all/builders/x86%20Tiger%203.x/builds/6826/steps/test/logs/stdio

"""
1030 # We restore the old limit as soon as possible. If doing it
1031 # using addCleanup(), code running in between would fail
1032 # creating any file descriptor.
1033 resource.setrlimit(resource.RLIMIT_NOFILE, (soft_limit, hard_limit))
"""

The code trying to reset RLIMIT_NOFILE to its previous value fails,
and as a consequence, all subsequent FDs creation fail (since the soft
limit it 1)...

It looks like Tiger getrlimit() return a nonsensical value (maybe -1),
which means that you can't do setrlimit(getrlimit()), or yet another
OS X bug (TM).
See e.g. http://www.couchbase.com/issues/browse/MB-3064

I'd suggest two things:
- skip it on Tiger (using support.requires_mac_vers() decorator)
- run the test in a subprocess (using the test in your latest patch
would be fine), to be more robust against this
History
Date User Action Args
2013-08-24 17:49:35neologixsetrecipients: + neologix, jcea, pitrou, vstinner, christian.heimes, tarek, alex, python-dev, hynek, dstufft
2013-08-24 17:49:35neologixlinkissue18756 messages
2013-08-24 17:49:35neologixcreate