Message195328
Great catch, Charles-François, thanks. It's actually an interesting example in favor of the approach - it's very nice to see descriptive family names in the data returned by getaddrinfo, instead of obtuse numeric values.
The attached patch fixes it in a similar vein to what was done for the family accessor: getaddrinfo is overridden in Python and does the necessary conversion. User code is unaffected. It has to rebuild the list (since those are tuples) but I don't think it matters in terms of performance for this specific function. As a bonus, getaddrinfo got a much nicer docstring :)
----
Note again that if this is acceptable, I'm going to similarly convert SOCK_* and post a full patch (with some documentation too). |
|
Date |
User |
Action |
Args |
2013-08-16 13:28:34 | eli.bendersky | set | recipients:
+ eli.bendersky, gvanrossum, barry, ncoghlan, pitrou, christian.heimes, neologix, ethan.furman, serhiy.storchaka |
2013-08-16 13:28:34 | eli.bendersky | set | messageid: <1376659714.45.0.127474841484.issue18720@psf.upfronthosting.co.za> |
2013-08-16 13:28:34 | eli.bendersky | link | issue18720 messages |
2013-08-16 13:28:34 | eli.bendersky | create | |
|