Author vstinner
Recipients ezio.melotti, mrabarnett, pitrou, serhiy.storchaka, tim.peters, vstinner
Date 2013-08-13.22:57:44
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1376434665.04.0.430702180637.issue18685@psf.upfronthosting.co.za>
In-reply-to
Content
Using #include "_sre.c" in _sre.c looks weird. Instead of huge sections delimited by "#ifdef SRE_RECURSIVE", I would prefer something similar to the stringlib. ".h" template files included more than once. I also expect shorter files: _sre.c is close to 4000 lines of C code :-(

If you move code from _sre.c to a new file, you should use "hg cp" to keep the history. For the review, it's maybe better to continue with your SRE_RECURSIVE hack :)

--

#define SRE_CHAR Py_UCS1
#define SIZEOF_SRE_CHAR 1
..
#define SRE_CHAR Py_UCS2
#define SIZEOF_SRE_CHAR 1
...
#define SRE_CHAR Py_UCS4
#define SIZEOF_SRE_CHAR 1

The value of SIZEOF_SRE_CHAR looks suspicious.

Does test_re have some non-ASCII tests? If not, we should probably start by adding such tests!
History
Date User Action Args
2013-08-13 22:57:45vstinnersetrecipients: + vstinner, tim.peters, pitrou, ezio.melotti, mrabarnett, serhiy.storchaka
2013-08-13 22:57:45vstinnersetmessageid: <1376434665.04.0.430702180637.issue18685@psf.upfronthosting.co.za>
2013-08-13 22:57:45vstinnerlinkissue18685 messages
2013-08-13 22:57:44vstinnercreate