Author vajrasky
Recipients ajaksu2, catherinedevlin, christian.heimes, daniel.ugra, eric.araujo, georg.brandl, jlgijsbers, mcjeff, pitrou, tarek, thomaswaldmann, vajrasky
Date 2013-08-01.04:35:31
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1375331731.86.0.121049235479.issue1666318@psf.upfronthosting.co.za>
In-reply-to
Content
Hi Catherine,

I saw your patch. It looks good, except you are trying to copy the directory onto its subdirectory.

src_dir = tempfile.mkdtemp()
dst_dir = os.path.join(tempfile.mkdtemp(), 'destination')

I prefer it if you copy it to somewhere else. This would be better:

tmp_dir = self.mkdtemp()
src = os.path.join(tmp_dir, 'foo')
dst = os.path.join(tmp_dir, 'bar')
History
Date User Action Args
2013-08-01 04:35:31vajraskysetrecipients: + vajrasky, georg.brandl, jlgijsbers, thomaswaldmann, pitrou, catherinedevlin, christian.heimes, ajaksu2, tarek, eric.araujo, daniel.ugra, mcjeff
2013-08-01 04:35:31vajraskysetmessageid: <1375331731.86.0.121049235479.issue1666318@psf.upfronthosting.co.za>
2013-08-01 04:35:31vajraskylinkissue1666318 messages
2013-08-01 04:35:31vajraskycreate