Author gregory.p.smith
Recipients emptysquare, gregory.p.smith, neologix, sbt
Date 2013-07-15.19:15:57
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1373915757.43.0.66332938347.issue18418@psf.upfronthosting.co.za>
In-reply-to
Content
This patch makes sense to me.  I've gone over the code and I cannot spot any adverse effects.  I was wondering in particular if anything would be surprised to find a non-started thread in _active within the short window where that will be true but nothing appears to care about that.

You should add a comment to the code mentioning this issue and why the .set() is done after the _active insertion.  After that, I'd say commit it.

If you want a consistent reproducible test case for this I believe you will need to replace the Thread object's __started with a test wrapper who's set() method blocks waiting for for the fork to have happened before doing the actual set().  That is a bit tricky and may not be worth it.
History
Date User Action Args
2013-07-15 19:15:57gregory.p.smithsetrecipients: + gregory.p.smith, neologix, sbt, emptysquare
2013-07-15 19:15:57gregory.p.smithsetmessageid: <1373915757.43.0.66332938347.issue18418@psf.upfronthosting.co.za>
2013-07-15 19:15:57gregory.p.smithlinkissue18418 messages
2013-07-15 19:15:57gregory.p.smithcreate