This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author JayKrish
Recipients JayKrish, Todd.Rovito, philwebster, terry.reedy
Date 2013-07-14.06:50:44
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1373784645.92.0.956244200075.issue18425@psf.upfronthosting.co.za>
In-reply-to
Content
Now we have the mockText, So I updated my test for Idlehistory.
The submitted patch2 contains tests for two methods in Idlehistory (history_store and History_do).
I hope the tests for history_store are done. But the history_do method tests fails.
I explored a bit on the failure trace,
History_do method is called by PyShell.py
before it calls, pyShell does self.text.mark_set("iomark", "insert") and passes the Text to IdleHistory.
Now Idlehistory uses 'iomark' as an index.
Mock Text's _decode only handles specific input indexes (as it mentions), that means this 'iomark' index failed to all the logic of _decode method and finally crosses   line, char = index.split('.') line which eventually raises a ValueError: need more than 1 value to unpack.

One option is to create an issue to futher develop mock Text and implement mark_set also the _decode and so on,
or Is it sounds like making stuffs more complex?, so we may decide the implemented tests are adequate enough for now.
History
Date User Action Args
2013-07-14 06:50:46JayKrishsetrecipients: + JayKrish, terry.reedy, Todd.Rovito, philwebster
2013-07-14 06:50:45JayKrishsetmessageid: <1373784645.92.0.956244200075.issue18425@psf.upfronthosting.co.za>
2013-07-14 06:50:45JayKrishlinkissue18425 messages
2013-07-14 06:50:45JayKrishcreate