This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author esc24
Recipients chris.jerdonek, esc24, ezio.melotti, vstinner, zach.ware
Date 2013-07-06.10:30:23
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1373106624.52.0.305328941821.issue16000@psf.upfronthosting.co.za>
In-reply-to
Content
I think this is a real improvement. Thanks. I have a few comments:

I suspect you know this, but the rendering problem occurs because of the call to curses.endwin() in tearDown(). I experimented with delaying this until teadDownClass() but this led to even more undesirable side effects with the tests running in parallel. Your print() call seems like a simple workaround.

There is only a single test case so I don't see the advantage of using a setUpModule function over setUpClass. Is there one? I'd put the code in setUpClass (or possibly put the curses.setupterm() call in setUp and have neither setUpModule or setUpClass). If and when further test cases are added I'd consider factoring out common code into a setUpModule. I'd also consider putting the skip test if not sys.__stdout__.isatty() that's in your current setUpModule as a decorator with the other @unittest.skipIf class decorators. Is there a reason you singled this one out to go in setUpModule?

You have a typo on line 30: 'unkwown' should be 'unknown'
History
Date User Action Args
2013-07-06 10:30:24esc24setrecipients: + esc24, vstinner, ezio.melotti, chris.jerdonek, zach.ware
2013-07-06 10:30:24esc24setmessageid: <1373106624.52.0.305328941821.issue16000@psf.upfronthosting.co.za>
2013-07-06 10:30:24esc24linkissue16000 messages
2013-07-06 10:30:23esc24create