➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients brian.curtin, mark.dickinson, pitrou, python-dev, sbt, serhiy.storchaka, tim.golden, vstinner
Date 2013-06-05.21:40:09
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1370468409.93.0.205361547573.issue17931@psf.upfronthosting.co.za>
In-reply-to
Content 
-/* The size of `pid_t' (HANDLE). */
-#define SIZEOF_PID_T SIZEOF_VOID_P

I would prefer to have SIZEOF_PID_T defined:
#define SIZEOF_PID_T SIZEOF_INT

win32_kill() uses DWORD type, not pid_t.

Except these nits, your patch looks good and is more correct than my patch.
History
Date User Action Args
2013-06-05 21:40:09vstinnersetrecipients: + vstinner, mark.dickinson, pitrou, tim.golden, brian.curtin, python-dev, sbt, serhiy.storchaka
2013-06-05 21:40:09vstinnersetmessageid: <1370468409.93.0.205361547573.issue17931@psf.upfronthosting.co.za>
2013-06-05 21:40:09vstinnerlinkissue17931 messages
2013-06-05 21:40:09vstinnercreate