This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author sbt
Recipients BreamoreBoy, brian.curtin, sbt, terry.reedy, tim.golden, zach.ware
Date 2013-05-28.20:06:19
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
I can't say I know enough about batch files to understand much of the code, but a few notes:

Windows XP does not have the command "where" which you use -- Python 3.4 will still support XP.

Except perhaps for looping I would prefer to get rid of the use of goto.  The fact that some goto targets end in "exit /b ..." make it very confusing as to where "exit /b" will return control.

The initial pushd is matched by various popd's which are scattered over hundreds of lines (including one in :usage).  I think it would be better to keep matching pushd/popd reasonably close together.  For instance, I think you could do something like

    pushd "%~dp0"
    call :main ...
    exit /b

    exit /b

It would also be helpful if the end of the subroutines were marked with a comment like

    rem end :foo
Date User Action Args
2013-05-28 20:06:19sbtsetrecipients: + sbt, terry.reedy, tim.golden, brian.curtin, BreamoreBoy, zach.ware
2013-05-28 20:06:19sbtsetmessageid: <>
2013-05-28 20:06:19sbtlinkissue16895 messages
2013-05-28 20:06:19sbtcreate