Author eli.bendersky
Recipients alex, barry, benjamin.peterson, docs@python, dstufft, eli.bendersky, ethan.furman, ezio.melotti, gvanrossum, isoschiz, ncoghlan, pconnell, python-dev, zach.ware
Date 2013-05-26.20:56:08
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1369601769.16.0.354457557401.issue17947@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks Ethan :)

From my point of view this is LGTM, as long as:

* There's ReST documentation
* You remove the code to support extensions and customizations not mandated by PEP 435. As I mentioned before, this seems to be a YAGNI that complicates the code needlessly. It's find to keep the changes in some external repo and at a later point discuss their gradual addition similarly to the way Nick has been pushing enhancements through additional issues.

We can always add more capabilities to Enum. We can "never" take them away once added, and this complicated code will remain with us forever even if no one ends up using it.
History
Date User Action Args
2013-05-26 20:56:09eli.benderskysetrecipients: + eli.bendersky, gvanrossum, barry, ncoghlan, benjamin.peterson, ezio.melotti, alex, docs@python, ethan.furman, python-dev, zach.ware, pconnell, dstufft, isoschiz
2013-05-26 20:56:09eli.benderskysetmessageid: <1369601769.16.0.354457557401.issue17947@psf.upfronthosting.co.za>
2013-05-26 20:56:09eli.benderskylinkissue17947 messages
2013-05-26 20:56:08eli.benderskycreate