Author amaury.forgeotdarc
Recipients amaury.forgeotdarc, dongying, eli.bendersky, ezio.melotti, flox, serhiy.storchaka, terry.reedy, vstinner
Date 2013-05-21.20:59:40
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1369169981.17.0.399010172165.issue13612@psf.upfronthosting.co.za>
In-reply-to
Content
The patch goes in the right direction: consistently reject non-8bit encodings which the current implementation does not support.
- please add a unit test
- remove usage of PyUnicodeObject and the "Stupid to access directly" comment, they are outdated.

Real support for GBK is more work, http://wang.yuxuan.org/blog/?itemid=63 shows how to set a conversion callback. It will difficult to implement in the general case, see my older comment.
History
Date User Action Args
2013-05-21 20:59:41amaury.forgeotdarcsetrecipients: + amaury.forgeotdarc, terry.reedy, vstinner, ezio.melotti, eli.bendersky, flox, dongying, serhiy.storchaka
2013-05-21 20:59:41amaury.forgeotdarcsetmessageid: <1369169981.17.0.399010172165.issue13612@psf.upfronthosting.co.za>
2013-05-21 20:59:41amaury.forgeotdarclinkissue13612 messages
2013-05-21 20:59:40amaury.forgeotdarccreate