Author ned.deily
Recipients benjamin.peterson, doko, ned.deily
Date 2013-05-15.23:37:43
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1368661063.81.0.616710425049.issue17990@psf.upfronthosting.co.za>
In-reply-to
Content
For Issue17086, 8ee6d96a1019 backported some cross-build patches to the 2.7 branch.  The changes to setup.py detect_modules differ in the backport from those in default. In particular, in default, changes to the library and include directory lists used to build extensions modules are only made conditionally when cross-compiling.  But the 2.7 backport makes these changes unconditionally.

default:
    def detect_modules(self):
        # Ensure that /usr/local is always used, but the local build
        # directories (i.e. '.' and 'Include') must be first.  See issue
        # 10520.
        if not cross_compiling:
            add_dir_to_list(self.compiler.library_dirs, '/usr/local/lib')
            add_dir_to_list(self.compiler.include_dirs, '/usr/local/include')
        # only change this for cross builds for 3.3, issues on Mageia
        if cross_compiling:
            self.add_gcc_paths()
        self.add_multiarch_paths()

2.7:
    def detect_modules(self):
        # Ensure that /usr/local is always used
        add_dir_to_list(self.compiler.library_dirs, '/usr/local/lib')
        add_dir_to_list(self.compiler.include_dirs, '/usr/local/include')
        self.add_gcc_paths()
        self.add_multiarch_paths()

This breaks certain universal build combinations on OS X when using SDKs and it is possible it could break builds on other platforms as well.  Substituting the default branch code on 2.7 appears to solve the OS X build problem.  Whether it has any negative impact on other builds, in particular cross-compilations is untested.
History
Date User Action Args
2013-05-15 23:37:43ned.deilysetrecipients: + ned.deily, doko, benjamin.peterson
2013-05-15 23:37:43ned.deilysetmessageid: <1368661063.81.0.616710425049.issue17990@psf.upfronthosting.co.za>
2013-05-15 23:37:43ned.deilylinkissue17990 messages
2013-05-15 23:37:43ned.deilycreate