Author mirabilos
Recipients Ramchandra Apte, alanh, christian.heimes, ezio.melotti, jcea, mirabilos, pitrou, serhiy.storchaka, skrah, trent
Date 2013-05-11.13:08:16
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1368277696.13.0.730956817685.issue17237@psf.upfronthosting.co.za>
In-reply-to
Content
Right, keeping it simple helps in preventing accidents, and the code block looks full of magic enough as-is.

Maybe add a comment block that says:

/*
 * m68k is a bit different from most architectures in that objects
 * do not use "natural alignment" - for example, int and long are
 * only aligned at 2-byte boundaries. Tests have shown that skipping
 * the "optimised version" will even speed up m68k, so we #ifdef
 * for "the odd duck out" here.
 */

Then we have an in-situ documentation point for why that ifdef is there and why m68k is “the odd duck” and this whitelist method is used.
History
Date User Action Args
2013-05-11 13:08:16mirabilossetrecipients: + mirabilos, jcea, pitrou, christian.heimes, trent, ezio.melotti, alanh, skrah, Ramchandra Apte, serhiy.storchaka
2013-05-11 13:08:16mirabilossetmessageid: <1368277696.13.0.730956817685.issue17237@psf.upfronthosting.co.za>
2013-05-11 13:08:16mirabiloslinkissue17237 messages
2013-05-11 13:08:16mirabiloscreate