Author Nidan
Recipients Nidan, giampaolo.rodola, josiahcarlson, python-dev, stutzbach
Date 2013-05-01.10:54:46
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1367405687.27.0.33607733607.issue16133@psf.upfronthosting.co.za>
In-reply-to
Content
Why should asynchat.handle_read care about closed sockets if asyncore.recv does that already?
Currently asynchat.handle_read handles empty strings from asycore.recv gracefully (by doing some unnecessary work aka executing the remainder of the function), it doesn't treat them specially. The only path that might cause asynchat.handle_read to close the socket requires asycore.recv to throw.
Introducing None as possible return value from asyncore.recv therefore seems unnecessary to me.

Changed the patch accordingly.
History
Date User Action Args
2013-05-01 10:54:47Nidansetrecipients: + Nidan, josiahcarlson, giampaolo.rodola, stutzbach, python-dev
2013-05-01 10:54:47Nidansetmessageid: <1367405687.27.0.33607733607.issue16133@psf.upfronthosting.co.za>
2013-05-01 10:54:47Nidanlinkissue16133 messages
2013-05-01 10:54:47Nidancreate