Author isoschiz
Recipients christian.heimes, flox, isoschiz, jcea, pitrou, r.david.murray, serhiy.storchaka, sijinjoseph
Date 2013-04-21.17:06:42
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <2514D251-7C65-4823-B70C-1B61653CE6F8@ensoft.co.uk>
In-reply-to <1366562327.82.0.146401498319.issue17618@psf.upfronthosting.co.za>
Content
On 21 Apr 2013, at 17:38, Serhiy Storchaka <report@bugs.python.org> wrote:
> Serhiy Storchaka added the comment:
> 
> As for interface, I think 'adobe' flag should be false by default. It makes encoder simpler. ascii85 encoder in Go's standard library doesn't wrap nor add Adobe's brackets. btoa/atob functions looks redundant as we can just use a85encode/a85decoder with appropriate options. Perhaps we should get rid from 'adobe' flag in a85decode and autodetect it. And perhaps to do the same with other a85decode's options.

The problem with autodetecting is that it makes it impossible for an application to use this library to verify that something is encoded in a specific way. Explicit is better than implicit. 

Otherwise, your changes look good to me.
History
Date User Action Args
2013-04-21 17:06:42isoschizsetrecipients: + isoschiz, jcea, pitrou, christian.heimes, r.david.murray, flox, sijinjoseph, serhiy.storchaka
2013-04-21 17:06:42isoschizlinkissue17618 messages
2013-04-21 17:06:42isoschizcreate