Message187477
There are some bugs in ascii85 end base85 implementations (see in Rietveld for details). Besides, ascii85 implementation was too slow. I've prepared a patch that corrects errors and speeds up encoding and decoding.
Microbenchmarks:
./python -m timeit -r 1 -n 1 -s "from base64 import a85encode as encode; data = open('python', 'rb').read(1000001)" "encode(data)"
./python -m timeit -r 1 -n 1 -s "from base64 import b85encode as encode; data = open('python', 'rb').read(1000001)" "encode(data)"
./python -m timeit -r 1 -n 1 -s "from base64 import a85encode as encode, a85decode as decode; data = encode(open('python', 'rb').read(1000001))" "decode(data)"
./python -m timeit -r 1 -n 1 -s "from base64 import b85encode as encode, b85decode as decode; data = encode(open('python', 'rb').read(1000001))" "decode(data)"
Old patch New patch
a85encode 8.4 sec 1.13 sec
b85encode 1.35 sec 1.09 sec
a85decode 9.28 sec 3.29 sec
b85decode 3.17 sec 2.37 sec |
|
Date |
User |
Action |
Args |
2013-04-20 23:23:41 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, jcea, pitrou, christian.heimes, r.david.murray, flox, sijinjoseph, isoschiz |
2013-04-20 23:23:41 | serhiy.storchaka | set | messageid: <1366500221.32.0.0699469197309.issue17618@psf.upfronthosting.co.za> |
2013-04-20 23:23:41 | serhiy.storchaka | link | issue17618 messages |
2013-04-20 23:23:41 | serhiy.storchaka | create | |
|