Author pitrou
Recipients isoschiz, mark.dickinson, meador.inge, pitrou, serhiy.storchaka, skrah
Date 2013-04-20.22:15:32
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1366496130.3773.1.camel@fsol>
In-reply-to <21C84581-42B1-4212-AB79-724A780BF077@ensoft.co.uk>
Content
> - I'm no expert on the C API, but in s_iter_unpack do you not need to
> check for failure of PyType_GenericAlloc before calling
> PyObject_GetBuffer?

Yes, good catch.

> - I'm not a fan of separate iter_ functions (and there seemed to be a
> general move away from them elsewhere in Python3; obviously here we
> have to maintain backwards compat though). Perhaps a boolean keyword
> "asiter" arg to the regular unpack() instead?

We generally consider it bad API design when a parameter changes the
return *type* of the function. "iter_unpack" may not be terrific as a
name but it describes the semantics quite clearly (and it's not too
annoying to type).
History
Date User Action Args
2013-04-20 22:15:32pitrousetrecipients: + pitrou, mark.dickinson, skrah, meador.inge, serhiy.storchaka, isoschiz
2013-04-20 22:15:32pitroulinkissue17804 messages
2013-04-20 22:15:32pitroucreate