Author isoschiz
Recipients isoschiz, mark.dickinson, meador.inge, pitrou, serhiy.storchaka, skrah
Date 2013-04-20.22:01:14
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <21C84581-42B1-4212-AB79-724A780BF077@ensoft.co.uk>
In-reply-to <1366493865.01.0.0658316297389.issue17804@psf.upfronthosting.co.za>
Content
I like the idea of this. Two comments:

- I'm no expert on the C API, but in s_iter_unpack do you not need to check for failure of PyType_GenericAlloc before calling PyObject_GetBuffer?

- I'm not a fan of separate iter_ functions (and there seemed to be a general move away from them elsewhere in Python3; obviously here we have to maintain backwards compat though). Perhaps a boolean keyword "asiter" arg to the regular unpack() instead?
History
Date User Action Args
2013-04-20 22:01:15isoschizsetrecipients: + isoschiz, mark.dickinson, pitrou, skrah, meador.inge, serhiy.storchaka
2013-04-20 22:01:15isoschizlinkissue17804 messages
2013-04-20 22:01:14isoschizcreate