Author r.david.murray
Recipients giampaolo.rodola, loewis, mmilkin, r.david.murray
Date 2013-04-20.18:09:08
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1366481349.32.0.886973209358.issue9682@psf.upfronthosting.co.za>
In-reply-to
Content
The message in both branches of the if talk about empty labels, which is probably my fault since I got the sense of the if wrong in my suggestion.  One of them should be about the label being too long.  The one that should be the 'empty' message also doesn't read right to my eyes.  As I said I think it should be something like: '"empty label in %r" % result.decode()'.

Also, in looking at the module code, there are several other places where the size check and simple message are used.  In all of these cases the string has already been confirmed to be (or converted to, in the case of the punycoding) ASCII.  So we can abstract this check into a function and call it from all those locations.

Do you want to update the patch accordingly, Mike?  It will need more tests.
History
Date User Action Args
2013-04-20 18:09:09r.david.murraysetrecipients: + r.david.murray, loewis, giampaolo.rodola, mmilkin
2013-04-20 18:09:09r.david.murraysetmessageid: <1366481349.32.0.886973209358.issue9682@psf.upfronthosting.co.za>
2013-04-20 18:09:09r.david.murraylinkissue9682 messages
2013-04-20 18:09:08r.david.murraycreate