Author r.david.murray
Recipients BreamoreBoy, Stijn.Hoop, ankitoshniwal, dfranke, loewis, mcjeff, r.david.murray
Date 2013-04-18.11:50:04
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1366285804.86.0.92797062201.issue5004@psf.upfronthosting.co.za>
In-reply-to
Content
The problem with your patch is that it changes the (effective) meaning of the 'name' parameter.  Before the patch, name can be an IP address.  After the patch, that will fail on Fedora.  (It also fails on my Gentoo system).

It is interesting to note, as well, that the documentation for gethostbyaddr says that it is obsolete and getaddrinfo should be used instead.

Could we use the getaddrinfo call if we don't get an FQDN back from gethostbyaddr?  It doesn't look like that would completely solve your problem, though, given your example output.  Have you figured out why that is happening? 

Alternatively, perhaps we could fall back to gethostbyaddr if we don't get an fqdn from the getaddrinfo call.  

However, given that the documentation actually specifies the algorithm used by getfqdn, I'm not sure if we can make either change in a bugfix version.
History
Date User Action Args
2013-04-18 11:50:04r.david.murraysetrecipients: + r.david.murray, loewis, dfranke, mcjeff, BreamoreBoy, ankitoshniwal, Stijn.Hoop
2013-04-18 11:50:04r.david.murraysetmessageid: <1366285804.86.0.92797062201.issue5004@psf.upfronthosting.co.za>
2013-04-18 11:50:04r.david.murraylinkissue5004 messages
2013-04-18 11:50:04r.david.murraycreate