Author serhiy.storchaka
Recipients christian.heimes, flox, isoschiz, jcea, pitrou, r.david.murray, serhiy.storchaka, sijinjoseph
Date 2013-04-17.13:58:49
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1366207129.91.0.146197556528.issue17618@psf.upfronthosting.co.za>
In-reply-to
Content
After a more careful look of the b85encode code I say that it's implementation is not optimal. For the sake of simplicity the entire volume of data is copied several times. This can affect the processing of a large volume of data. On other hand, this dumb copying can be faster then more smart processing in a85encode. Only benchmarks will show the truth.

Using a trick with struct.unpack() has very unpleasant side effect. It might be a few speed up encoding, but creates the Struct object with the size is many times larger than the size of the processed data. Worse, this object is cached and continues to consume memory. Since the size of the data most likely will be unique, almost every call of b85encode creates a new object. This will lead to memory leaks.
History
Date User Action Args
2013-04-17 13:58:49serhiy.storchakasetrecipients: + serhiy.storchaka, jcea, pitrou, christian.heimes, r.david.murray, flox, sijinjoseph, isoschiz
2013-04-17 13:58:49serhiy.storchakasetmessageid: <1366207129.91.0.146197556528.issue17618@psf.upfronthosting.co.za>
2013-04-17 13:58:49serhiy.storchakalinkissue17618 messages
2013-04-17 13:58:49serhiy.storchakacreate