This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eli.bendersky
Recipients Ankur.Ankan, cbc, chris.jerdonek, eli.bendersky
Date 2013-04-10.12:55:57
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1365598557.7.0.677363603952.issue15518@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks, looks much better now. I left a couple of small comments in the code review. Other than that, it makes sense to me to update the existing tests to follow this scheme as well. Thanks!

On a related note, since you've obviously studied the filecmp module's operation to a great depth, your input on http://bugs.python.org/issue15430 would be appreciated.
History
Date User Action Args
2013-04-10 12:55:57eli.benderskysetrecipients: + eli.bendersky, chris.jerdonek, cbc, Ankur.Ankan
2013-04-10 12:55:57eli.benderskysetmessageid: <1365598557.7.0.677363603952.issue15518@psf.upfronthosting.co.za>
2013-04-10 12:55:57eli.benderskylinkissue15518 messages
2013-04-10 12:55:57eli.benderskycreate