Message186488
Thanks, looks much better now. I left a couple of small comments in the code review. Other than that, it makes sense to me to update the existing tests to follow this scheme as well. Thanks!
On a related note, since you've obviously studied the filecmp module's operation to a great depth, your input on http://bugs.python.org/issue15430 would be appreciated. |
|
Date |
User |
Action |
Args |
2013-04-10 12:55:57 | eli.bendersky | set | recipients:
+ eli.bendersky, chris.jerdonek, cbc, Ankur.Ankan |
2013-04-10 12:55:57 | eli.bendersky | set | messageid: <1365598557.7.0.677363603952.issue15518@psf.upfronthosting.co.za> |
2013-04-10 12:55:57 | eli.bendersky | link | issue15518 messages |
2013-04-10 12:55:57 | eli.bendersky | create | |
|